Resolve AttributeError: 'ScalaFunction1' object has no attribute 'hashCode'. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenliu0831
reviewed
Jan 18, 2024
| vrb.addCheck(check) | ||
| check.hasDataType("d", ConstrainableDataTypes.String, lambda x: x >= 1) | ||
| vrb.addCheck(check) |
There was a problem hiding this comment.
Why do we need to add and verify one by one?
There was a problem hiding this comment.
Because that is the use case for triggering the exception. If I change the test like so, it does not use hashCode.
vrb = VerificationSuite(self.spark) \
.onData(self.df)
check = Check(self.spark, CheckLevel.Error, "Enough checks to trigger a hashCode not an attribute of ScalaFunction1")
check.addConstraints([
check.isComplete('b'),
check.containsEmail('email'),
check.isGreaterThanOrEqualTo("d", "b"),
check.isLessThanOrEqualTo("b", "d"),
check.hasDataType("d", ConstrainableDataTypes.String, lambda x: x >= 1)])
result = vrb.addCheck(check).run()
There was a problem hiding this comment.
Does it only fail at the magic 5th one? It's a big strange if so.. btw CI is failing on this test
There was a problem hiding this comment.
The issue write up has more info: #91
There was a problem hiding this comment.
I can't replicate the error in CI but submitted an attempt to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#91
Description of changes:
Added
hashCode()method toScalaFunction1andScalaFunction2.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.